Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDA grpc config for SR Linux nodes #2368

Merged
merged 4 commits into from
Jan 3, 2025
Merged

EDA grpc config for SR Linux nodes #2368

merged 4 commits into from
Jan 3, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Dec 30, 2024

eda-discobery, eda-mgmt, and eda-insecure-mgmt servers are added with custom ports to support eda management

when CLAB_EDA_USE_DEFAULT_GRPC_SERVER env var is set, instead of adding custom eda-mgmt and eda-insecure-mgmt servers, the EDA TLS profile is added to the default mgmt grpc server.

@hellt hellt merged commit 0d030b4 into main Jan 3, 2025
66 of 67 checks passed
@hellt hellt deleted the eda-grpc branch January 3, 2025 10:19
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (6976a16) to head (9b60795).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
nodes/srl/version.go 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
- Coverage   51.79%   51.77%   -0.02%     
==========================================
  Files         172      172              
  Lines       17243    17255      +12     
==========================================
+ Hits         8931     8934       +3     
- Misses       7371     7377       +6     
- Partials      941      944       +3     
Files with missing lines Coverage Δ
nodes/srl/srl.go 57.98% <ø> (ø)
nodes/srl/version.go 75.43% <66.66%> (-1.65%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant