Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to index, .gitignore #14

Merged
merged 4 commits into from
Aug 3, 2018
Merged

Conversation

skinn009
Copy link
Contributor

@skinn009 skinn009 commented Aug 3, 2018

Added pycharm environment control files to .gitignore.

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files           7        7           
  Lines         231      231           
=======================================
  Hits          227      227           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6735e9...96ae53b. Read the comment docs.

Copy link
Member

@hayesall hayesall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, should be fine to merge into master.

@skinn009
Copy link
Contributor Author

skinn009 commented Aug 3, 2018 via email

@hayesall
Copy link
Member

hayesall commented Aug 3, 2018

@skinn009 Yep. You should have a "Merge pull request" option now that the changes are approved, if it isn't appearing let me know (I was tweaking some access options when adding you and Yuqiao, but if it isn't appearing I should be able to fix it).

@skinn009 skinn009 merged commit 780c270 into srlearn:master Aug 3, 2018
@skinn009
Copy link
Contributor Author

skinn009 commented Aug 3, 2018

Edits to documentation.

@skinn009
Copy link
Contributor Author

skinn009 commented Aug 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants