Development #18
Merged
Development #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding ann explicit docstring to the __main__ section of tests.py. Adding flag to control verbosity of testing. Raising an explicit exception when errors or failures are encountered. * Adding amore significant tests to test_parse.py. Previously the test did not properly assert whether the files created actually matched expectations, now they do. * Similar treatment as the previous commit, but now with respect to test_converter.py * Rather than storing the expected contents of files, md5 hashes of the expected outputs are stored and verified after running.
* Overwriting install in setup.py to also download nltk packages which are required by rnlp. * Bumping version number in _rnlp.__init__ to match the update to the setup file.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 98.26% 95.48% -2.79%
==========================================
Files 7 8 +1
Lines 231 310 +79
==========================================
+ Hits 227 296 +69
- Misses 4 14 +10
Continue to review full report at Codecov.
|
* Separating sections of the documentation into getting_started and api_reference sections. Clearing up the table of contents to reflect this fix. * Creating an img folder under _static and updating 03_quickstart.rst to reference the output.png image located here. * Adding a gif and more explanation to the home page. * Separating the document conversion section of the quickstart guide from the learning section. 04_learning.rst contains some of the commands for running BoostSRL. * Updating the learning task description and adding an output image for the model learned from the list of grievances. This commit also modified the doi.txt example file, some lines ended with a colon which made nltk sentence splitting a bit strange.
…m the documentation and web page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge development branch into master, with setup.py corrected and creating more robust tests (hashing the output files to ensure they match);.