Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '--no-logs' option to argument parser #22

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

adamjsawicki
Copy link
Contributor

@adamjsawicki adamjsawicki commented Jan 8, 2020

Fixes #8.

Also throws custom Exception if nltk or its needed modules are not properly installed.

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f3292d5). Click here to learn what that means.
The diff coverage is 98.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   94.97%           
=========================================
  Files             ?       10           
  Lines             ?      338           
  Branches          ?        0           
=========================================
  Hits              ?      321           
  Misses            ?       17           
  Partials          ?        0
Impacted Files Coverage Δ
rnlp/tests/rnlptests/test_parse.py 100% <100%> (ø)
rnlp/tests/rnlptests/test_converter.py 100% <100%> (ø)
rnlp/tests/rnlptests/test_textprocessing.py 100% <100%> (ø)
rnlp/tests/tests.py 90.9% <66.66%> (ø)
rnlp/parse.py 98.23% <98.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3292d5...7a3c632. Read the comment docs.

@adamjsawicki adamjsawicki changed the title WIP: Add '--no-logs' option to argument parser Add '--no-logs' option to argument parser Jan 24, 2020
@adamjsawicki adamjsawicki requested a review from hayesall January 24, 2020 17:26
Copy link
Member

@hayesall hayesall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The Travis build threw an error, but with 2.7 being end-of-life I'm not worried.

I'll make a maintenance update to drop it.

@hayesall hayesall merged commit 0cb209b into srlearn:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging should be optional
3 participants