Bugfixing and Refactoring parse.py #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d was at the end of the sentence, there may have been errors when running in practice.
…stead a second lateSentenceInBlock predicate was created). beginning and ending variables were being overwritten in the inner loop, so lateSentenceInBlock was almost never created.
…here it runs parse.makeIdentifiers, but this case only runs the code to ensure errors are not thrown, it does not validate that outputs match any expectation.
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
===========================================
+ Coverage 55.14% 98.26% +43.12%
===========================================
Files 5 7 +2
Lines 214 231 +17
===========================================
+ Hits 118 227 +109
+ Misses 96 4 -92
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request re-factors the
makeIdentifiers()function in parse.py and fixes a few fairly critical errors.makeIdentifiersis now imported by default when rnlp is imported.parse.makeIdentifiers()where the lateWordInSentence predicate was never created. In its place a second (and erroneous) lateSentenceInBlock predicate was created instead.text_string.strip(_punctuation)worked in most simple cases, but certain punctuation marks within sentences were problematic for BoostSRL's parser.