Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci integration #28

Merged
merged 23 commits into from
Jul 31, 2024
Merged

Ci integration #28

merged 23 commits into from
Jul 31, 2024

Conversation

Olthoff231381
Copy link
Collaborator

Many commits to get the CI working reliably but it now works

Olthoff231381 and others added 22 commits July 31, 2024 10:21
@Olthoff231381 Olthoff231381 requested a review from iulusoy July 31, 2024 11:37
iulusoy
iulusoy requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@iulusoy iulusoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small items, looks great otherwise.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Olthoff231381
Olthoff231381 commented Jul 31, 2024
View reviewed changes
Copy link
Collaborator Author

@Olthoff231381 Olthoff231381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted requirements install and added flags to pytest

@Olthoff231381
Copy link
Collaborator Author

Will fix the Quality Problem next push.
Just have to omit the conversion to path in parse.py

@Olthoff231381 Olthoff231381 merged commit 03880e7 into unitTest Jul 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulusoy iulusoy iulusoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Olthoff231381 @iulusoy