Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace emails, numbers and other NE by brackets #48

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

fexfl
Copy link
Collaborator

@fexfl fexfl commented Nov 3, 2024

  • Replaced numbers by [number]
  • Replaced organizations, locations and misc by brackets accordingly
  • Replaced emails by [email] before the NER step

@fexfl fexfl requested a review from iulusoy November 3, 2024 11:21
Copy link

sonarcloud bot commented Nov 3, 2024

@fexfl
Copy link
Collaborator Author

fexfl commented Nov 3, 2024

This should close #38

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (5a4dd30) to head (eefc73c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   92.02%   93.45%   +1.43%     
==========================================
  Files           4        4              
  Lines         326      382      +56     
==========================================
+ Hits          300      357      +57     
+ Misses         26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iulusoy iulusoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you click on "Merge" for merging the PR, can you change it to "Squash and Merge"? This squashes all commits in the PR into one and keeps the number of commits on main small.

@fexfl fexfl merged commit b9d14f8 into main Nov 5, 2024
7 checks passed
@fexfl fexfl deleted the pseudo-emails-numbers branch November 5, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants