-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the card gallery to one card on the main page #145
Conversation
Majapur1
commented
Nov 6, 2024
- Added one card to the home screen instead of the gallery (it stayed within the gallery, it is possible to add more cards if needed).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 30.39% 31.32% +0.93%
==========================================
Files 95 101 +6
Lines 3287 3339 +52
Branches 92 94 +2
==========================================
+ Hits 999 1046 +47
- Misses 2218 2221 +3
- Partials 70 72 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - made a couple of suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few remarks here and there.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkeegan Sorry, I did it wrong! Yes, you're right, all real changes are there. |
OK, let me rebase that commit on main then.. |
393e398
to
5db4581
Compare
@Majapur1 the easiest way for you to update your local branch now to match this one might be to delete it, then check it out again. Alternatively something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of suggestions, otherwise looks good!
Co-authored-by: Liam Keegan <[email protected]>
for more information, see https://pre-commit.ci
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!