Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the card gallery to one card on the main page #145

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

Majapur1
Copy link
Collaborator

@Majapur1 Majapur1 commented Nov 6, 2024

  • Added one card to the home screen instead of the gallery (it stayed within the gallery, it is possible to add more cards if needed).

@Majapur1 Majapur1 added javascript Pull requests that update Javascript code frontend labels Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 31.32%. Comparing base (d71691a) to head (9d5bf33).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/lib/components/FrontPageCard.svelte 0.00% 4 Missing and 1 partial ⚠️
frontend/src/lib/components/Frontpage.svelte 0.00% 1 Missing ⚠️
frontend/tailwind.config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   30.39%   31.32%   +0.93%     
==========================================
  Files          95      101       +6     
  Lines        3287     3339      +52     
  Branches       92       94       +2     
==========================================
+ Hits          999     1046      +47     
- Misses       2218     2221       +3     
- Partials       70       72       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - made a couple of suggestions

frontend/src/lib/assets/baby-flower.png Outdated Show resolved Hide resolved
frontend/src/lib/components/DataDisplay/CardDisplay.svelte Outdated Show resolved Hide resolved
Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few remarks here and there.

frontend/src/lib/assets/baby-flower.png Outdated Show resolved Hide resolved
frontend/src/lib/components/DataDisplay/CardDisplay.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/Frontpage.svelte Outdated Show resolved Hide resolved
@Majapur1
Copy link
Collaborator Author

Majapur1 commented Nov 14, 2024

  • add a card to the home page as a separate element

d537dbb

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Majapur1 - but this PR has got a bit confusing to review! (now 57 files changed & merge conflicts with main).

Am I right in thinking that the only changes you actually want to make here are the changes from your most recent commit?: d537dbb

@Majapur1
Copy link
Collaborator Author

Majapur1 commented Nov 14, 2024

thanks @Majapur1 - but this PR has got a bit confusing to review! (now 57 files changed & merge conflicts with main).

Am I right in thinking that the only changes you actually want to make here are the changes from your most recent commit?: d537dbb

@lkeegan Sorry, I did it wrong! Yes, you're right, all real changes are there.

d537dbb

@lkeegan
Copy link
Member

lkeegan commented Nov 14, 2024

OK, let me rebase that commit on main then..

@lkeegan
Copy link
Member

lkeegan commented Nov 14, 2024

@Majapur1 the easiest way for you to update your local branch now to match this one might be to delete it, then check it out again. Alternatively something like git reset HEAD~80 --hard && git pull should also work.

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of suggestions, otherwise looks good!

frontend/src/lib/components/Frontpage.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/Frontpage.svelte Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 14, 2024

@lkeegan lkeegan self-requested a review November 15, 2024 07:20
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lkeegan lkeegan merged commit e4ad2fc into main Nov 15, 2024
6 checks passed
@lkeegan lkeegan deleted the frontpage-card branch November 15, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants