Ensure MilestoneGroup.milestones is sorted correctly
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sort milestones list by ascending order of `Milestone.order` - update test data to include ordering that is not the same as the order of ids
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 27.88% 27.88%
=======================================
Files 93 93
Lines 3306 3306
Branches 90 90
=======================================
Hits 922 922
Misses 2316 2316
Partials 68 68 ☔ View full report in Codecov by Sentry. |
Majapur1
pushed a commit
that referenced
this pull request
Nov 14, 2024
- sort milestones list by ascending order of `Milestone.order` - update test data to include ordering that is not the same as the order of ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone.order