Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin ordering of items #161

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Nov 13, 2024

  • backend
    • add /*/order endpoints to re-order lists of
      • milestones
      • milestone-groups
      • child-questions
      • user-questions
  • admin frontend
    • add "reorder" button to all lists of items that can be ordered
    • add OrderItemsModal dialog to re-order items using drag&drop
    • add svelte-dnd-action library for drag&drop functionality
  • resolves order milestones by expected age? #141

Copy link

sonarcloud bot commented Nov 13, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 43.58974% with 44 lines in your changes missing coverage. Please review.

Project coverage is 30.39%. Comparing base (b75ded2) to head (a89c44b).

Files with missing lines Patch % Lines
...nd/src/lib/components/Admin/OrderItemsModal.svelte 0.00% 17 Missing and 1 partial ⚠️
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 14 Missing ⚠️
frontend/src/lib/components/Admin/Questions.svelte 0.00% 9 Missing ⚠️
...tend/src/lib/components/Admin/ReorderButton.svelte 0.00% 1 Missing and 1 partial ⚠️
frontend/src/lib/components/Admin/AddButton.svelte 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   30.01%   30.39%   +0.38%     
==========================================
  Files          93       95       +2     
  Lines        3212     3287      +75     
  Branches       90       92       +2     
==========================================
+ Hits          964      999      +35     
- Misses       2180     2218      +38     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan requested a review from MaHaWo November 13, 2024 16:18
- backend
  - add /*/order endpoints to re-order lists of
    - milestones
    - milestone-groups
    - child-questions
    - user-questions
- admin frontend
  - add "reorder" button to all lists of items that can be ordered
  - add OrderItemsModal dialog to re-order items using drag&drop
  - add svelte-dnd-action library for drag&drop functionality
- resolves #141
@lkeegan lkeegan force-pushed the add_admin_ordering_of_milestones branch from 3834d00 to a89c44b Compare November 14, 2024 13:19
Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lkeegan lkeegan merged commit d71691a into main Nov 14, 2024
5 checks passed
@lkeegan lkeegan deleted the add_admin_ordering_of_milestones branch November 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order milestones by expected age?
3 participants