-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow admins to view and edit users #168
Conversation
lkeegan
commented
Nov 14, 2024
- backend
- add /admin/users/ endpoint to get a list of users
- refactor admin endpoints into separate files for languages, milestones, users, questions
- refactor tests to also create a temporary in-memory users database for each test
- add pytest-asyncio to allow use of async fixtures
- refactor tests to be fully independent of each other
- new app & new temp dirs for each test
- makes test suite slower to run but easier to maintain
- remove DATA_FILES_PATH as we already have STATIC_FILES_PATH and PRIVATE_FILES_PATH
- admin-frontend
- add users tab with table of users whose permissions can be edited
- resolves Add Users tab to admin interface #164
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 30.39% 31.01% +0.61%
==========================================
Files 95 100 +5
Lines 3287 3373 +86
Branches 92 93 +1
==========================================
+ Hits 999 1046 +47
- Misses 2218 2256 +38
- Partials 70 71 +1 ☔ View full report in Codecov by Sentry. |
66f5aea
to
ae339c1
Compare
ae339c1
to
2e813dc
Compare
- backend - add /admin/users/ endpoint to get a list of users - refactor admin endpoints into separate files for languages, milestones, users, questions - refactor tests to also create a temporary in-memory users database for each test - add pytest-asyncio to allow use of async fixtures - refactor tests to be fully independent of each other - new app & new temp dirs for each test - makes test suite slower to run but easier to maintain - remove DATA_FILES_PATH as we already have STATIC_FILES_PATH and PRIVATE_FILES_PATH - admin-frontend - add users tab with table of users whose permissions can be edited - resolves #164
c1b3327
to
bf0f3dd
Compare
for more information, see https://pre-commit.ci
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be better to remove the default image entirely here.
true, but I'll do it in a separate PR, with all the unrelated refactoring this PR has already diverged enough from what its title claims it is about! |