Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an element "About" to the front page #170

Merged
merged 3 commits into from
Nov 20, 2024
Merged

add an element "About" to the front page #170

merged 3 commits into from
Nov 20, 2024

Conversation

Majapur1
Copy link
Collaborator

  • Information about MONDEY-project (text + image)

@Majapur1 Majapur1 added javascript Pull requests that update Javascript code frontend labels Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.95%. Comparing base (e355a44) to head (9a1d000).

Files with missing lines Patch % Lines
frontend/src/lib/components/FrontPageAbout.svelte 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   30.00%   29.95%   -0.05%     
==========================================
  Files          98       99       +1     
  Lines        3236     3241       +5     
  Branches       86       87       +1     
==========================================
  Hits          971      971              
- Misses       2194     2198       +4     
- Partials       71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Majapur1
Copy link
Collaborator Author

@lkeegan What could be the reason why I can't see the image I added?

@lkeegan
Copy link
Member

lkeegan commented Nov 15, 2024

@lkeegan What could be the reason why I can't see the image I added?

In the script part you need to do import babyFlower from "$lib/assets/babyFlower.jpg";

Then you can use this babyFlower variable for img, e.g. <Card img={babyFlower} ...>

@Majapur1
Copy link
Collaborator Author

@lkeegan ok, thanks!

@Majapur1
Copy link
Collaborator Author

Majapur1 commented Nov 18, 2024

Sorry, I've just made a same mistake... @lkeegan

Can I delete this pull request and make it again from scratch?

All real changes are here: b3445ac

Copy link

sonarcloud bot commented Nov 20, 2024

@lkeegan lkeegan merged commit dca2681 into main Nov 20, 2024
6 checks passed
@lkeegan lkeegan deleted the frontpage-about branch November 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants