Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

160 fix user login #171

Merged
merged 37 commits into from
Nov 15, 2024
Merged

160 fix user login #171

merged 37 commits into from
Nov 15, 2024

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Nov 15, 2024 •
edited
Loading

  • fix runes mode usage
  • make use of runes wherever appropriate
  • activate biome linter rules
  • fix the uncovered quality issues as far as possible, with 2 exceptions:
    • Flowbite-svelte components apparently don´t play nice with svelte 5 when being passed as arguments to other components and being used with out <svelte:component ... />
    • $locale is flagged as possibly null | undefined when using it as index variable, but I don´t see how this can happen in the current system.
  • delete AbstractContent component that is no longer needed
  • put tests for table functionality in separate file. this might go soon, but I'm hesitant to delete it.

@MaHaWo
use runes mode for login, add missing localization
7319940
@MaHaWo
make better use of stores
2e558af
@MaHaWo
work on refresh-login logic
b1202fd
@MaHaWo
Squashed commit of the following:
dc9e7d0 
commit 1e481ac
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 16:17:06 2024 +0100

    fix tests

commit 6079925
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Nov 13 15:06:43 2024 +0000

    update openapi.json & openapi-ts client

commit d207bab
Merge: 4b4a7e7 1496a3a
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 16:05:52 2024 +0100

    Merge branch 'main' into integrate-milestones-userland-with-backend

commit 4b4a7e7
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 15:42:41 2024 +0100

    adjust tests

commit 77ea2eb
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 15:24:26 2024 +0100

    fix backend error

commit 036f4ce
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Nov 13 13:14:35 2024 +0000

    update openapi.json & openapi-ts client

commit 2f64c56
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Wed Nov 13 13:13:52 2024 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit ef560b7
Merge: 8fad755 43bf1b3
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 14:13:26 2024 +0100

    Merge branch 'main' into integrate-milestones-userland-with-backend

commit 8fad755
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 14:06:02 2024 +0100

    fix child data loading bug, adjust breadcrumb navigation

commit b6e1452
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 13:47:15 2024 +0100

    work on styling, change navigation to something hopefully more intuitive, make more use of localization

commit 3012086
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 19:00:06 2024 +0100

    adjust styling

commit eb136b3
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 14:38:56 2024 +0100

    simplify progress computation, include milestone completion feedback

commit efae46f
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 13:28:56 2024 +0100

    modify progress reporting to be only a userland feature

commit 1dd97f7
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 11:46:21 2024 +0100

    add completion status to the milestone models

commit 06b6a2a
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 11:41:54 2024 +0100

    fix card styling, error message

commit 4e58cf8
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 16:56:51 2024 +0100

    integrate milestone

commit 166c18f
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 15:44:20 2024 +0100

    get milestone loading right

commit 7db9480
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 11:10:51 2024 +0100

    adjust milestonegroup to backend data

commit e7709d5
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 09:53:32 2024 +0100

    make use of states

commit 84c3f17
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 09:03:59 2024 +0100

    Squashed commit of the following:

    commit 43bf1b3
    Author: Liam Keegan <[email protected]>
    Date:   Mon Nov 11 08:17:47 2024 +0100

        Add admin option to delete milestone images (#150)

        * Add admin option to delete milestone images

        - add delete button below existing milestone images in admin interface
        - add delete /milestone-images endpoint
        - restate /admin route for convenience during development, can be removed again later
        - resolves #98

        * update openapi.json & openapi-ts client

        ---------

        Co-authored-by: Harald Mack <[email protected]>
        Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

    commit 33d4f17
    Author: Harald Mack <[email protected]>
    Date:   Fri Nov 8 17:23:58 2024 +0100

        Add childquestions backend integration and refactor datainput datastructure (#138)

        * add childanswers and base answer model

        * add child question models

        * add question admin endpoints

        * make current tests work again

        * adjust imports, add test skeleton

        * add dummy questions to test fixtures

        * start working on backend tests

        * work more on backend tests and model inheritance

        * fix errors in test data

        * try to get sqlmodel inheritnace to work

        * get rid of inheritance in question models for now

        * finish user question tests

        * finish python test draft

commit d900c19
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 08:56:33 2024 +0100

    work on localization, add setup-await pattern to milestoneoverview

commit be2393d
Author: Harald Mack <[email protected]>
Date:   Fri Nov 8 15:30:24 2024 +0100

    make data a member of currentChild for now, start integrating backend calls

commit 2254332
Author: Harald Mack <[email protected]>
Date:   Fri Nov 8 14:51:20 2024 +0100

    merge add-childquestion_backend-integration until
    32304c9
@MaHaWo
remove old userStore, remove separate adminstore, remove old basicSto…
4509b2e 
…re, adjustments for convenience
@MaHaWo
Squashed commit of the following:
d5109d5 
commit 7c01dce
Merge: 7ac5c7b 4e2a2ec
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 13:39:39 2024 +0100

    Merge branch 'integrate-milestones-userland-with-backend' of github.com:ssciwr/mondey into integrate-milestones-userland-with-backend

commit 7ac5c7b
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 13:39:35 2024 +0100

    remove debug output

commit 4e2a2ec
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Nov 14 12:39:35 2024 +0000

    update openapi.json & openapi-ts client

commit c9e4d97
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 13:38:11 2024 +0100

    put progress computation into frontend

commit 44100b0
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 12:59:41 2024 +0100

    fix styling issue

commit e233c63
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 12:47:22 2024 +0100

    remove searchByMilestone

commit 670bf04
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Nov 14 09:39:33 2024 +0000

    update openapi.json & openapi-ts client

commit 02841be
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 10:38:46 2024 +0100

    work on layout

commit 109ec0e
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 10:04:29 2024 +0100

    use tailwind for making labels visible/invisible

commit 42d239c
Author: Harald Mack <[email protected]>
Date:   Thu Nov 14 10:03:21 2024 +0100

    correct merge error

commit 1e481ac
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 16:17:06 2024 +0100

    fix tests

commit 6079925
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Nov 13 15:06:43 2024 +0000

    update openapi.json & openapi-ts client

commit d207bab
Merge: 4b4a7e7 1496a3a
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 16:05:52 2024 +0100

    Merge branch 'main' into integrate-milestones-userland-with-backend

commit 4b4a7e7
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 15:42:41 2024 +0100

    adjust tests

commit 77ea2eb
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 15:24:26 2024 +0100

    fix backend error

commit 036f4ce
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Nov 13 13:14:35 2024 +0000

    update openapi.json & openapi-ts client

commit 2f64c56
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Wed Nov 13 13:13:52 2024 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit ef560b7
Merge: 8fad755 43bf1b3
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 14:13:26 2024 +0100

    Merge branch 'main' into integrate-milestones-userland-with-backend

commit 8fad755
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 14:06:02 2024 +0100

    fix child data loading bug, adjust breadcrumb navigation

commit b6e1452
Author: Harald Mack <[email protected]>
Date:   Wed Nov 13 13:47:15 2024 +0100

    work on styling, change navigation to something hopefully more intuitive, make more use of localization

commit 3012086
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 19:00:06 2024 +0100

    adjust styling

commit eb136b3
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 14:38:56 2024 +0100

    simplify progress computation, include milestone completion feedback

commit efae46f
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 13:28:56 2024 +0100

    modify progress reporting to be only a userland feature

commit 1dd97f7
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 11:46:21 2024 +0100

    add completion status to the milestone models

commit 06b6a2a
Author: Harald Mack <[email protected]>
Date:   Tue Nov 12 11:41:54 2024 +0100

    fix card styling, error message

commit 4e58cf8
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 16:56:51 2024 +0100

    integrate milestone

commit 166c18f
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 15:44:20 2024 +0100

    get milestone loading right

commit 7db9480
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 11:10:51 2024 +0100

    adjust milestonegroup to backend data

commit e7709d5
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 09:53:32 2024 +0100

    make use of states

commit 84c3f17
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 09:03:59 2024 +0100

    Squashed commit of the following:

    commit 43bf1b3
    Author: Liam Keegan <[email protected]>
    Date:   Mon Nov 11 08:17:47 2024 +0100

        Add admin option to delete milestone images (#150)

        * Add admin option to delete milestone images

        - add delete button below existing milestone images in admin interface
        - add delete /milestone-images endpoint
        - restate /admin route for convenience during development, can be removed again later
        - resolves #98

        * update openapi.json & openapi-ts client

        ---------

        Co-authored-by: Harald Mack <[email protected]>
        Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

    commit 33d4f17
    Author: Harald Mack <[email protected]>
    Date:   Fri Nov 8 17:23:58 2024 +0100

        Add childquestions backend integration and refactor datainput datastructure (#138)

        * add childanswers and base answer model

        * add child question models

        * add question admin endpoints

        * make current tests work again

        * adjust imports, add test skeleton

        * add dummy questions to test fixtures

        * start working on backend tests

        * work more on backend tests and model inheritance

        * fix errors in test data

        * try to get sqlmodel inheritnace to work

        * get rid of inheritance in question models for now

        * finish user question tests

        * finish python test draft

commit d900c19
Author: Harald Mack <[email protected]>
Date:   Mon Nov 11 08:56:33 2024 +0100

    work on localization, add setup-await pattern to milestoneoverview

commit be2393d
Author: Harald Mack <[email protected]>
Date:   Fri Nov 8 15:30:24 2024 +0100

    make data a member of currentChild for now, start integrating backend calls

commit 2254332
Author: Harald Mack <[email protected]>
Date:   Fri Nov 8 14:51:20 2024 +0100

    merge add-childquestion_backend-integration until
    32304c9
@MaHaWo
merge main
b1ca221
@MaHaWo
work on removing svelte 5 deprecations and leftover debug output
9175d6d
@MaHaWo
reduce usage of deprecated functionality
ae54f91
@MaHaWo
undo some breaking changes
39507ac
@MaHaWo
remove svelte:component in carddisplay
986cdf1
@MaHaWo
remove flowbite gallery
4bbc1d8
@MaHaWo
use runes in gallerydisplay
eb78492
@MaHaWo
try to fix some code smells/typing issues
233eb5c
@MaHaWo
use more svelte 5 features, correct minor mistakes and type issues
efd32dd
@MaHaWo
activate more biome linter rules
a3c647b
@MaHaWo
relax any and console rule
cac5be9
@MaHaWo
work on gallerydisplay code issues
daebfa3
@MaHaWo
work on code quality of carddisplay
ec18f85
@MaHaWo
add type to util file
9f162db
@MaHaWo
allow forEach, console. log
ac8ffb1
@MaHaWo
work on code quality
c257b6e
@MaHaWo
work on fixing code quality issues uncovered by biome
bc4e585
@MaHaWo
add nonempty block
5d2e28a
@MaHaWo
add better output
52d452d
This was linked to issues Nov 15, 2024
Fix User login component, usage #160
Closed
frontend code quality #149
Closed
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.56072% with 350 lines in your changes missing coverage. Please review.

Project coverage is 29.99%. Comparing base (e4ad2fc) to head (f4cb0a7).

Files with missing lines Patch % Lines
...src/lib/components/DataDisplay/TableDisplay.svelte 0.00% 39 Missing and 1 partial ⚠️
frontend/src/lib/components/MilestoneGroup.svelte 0.00% 40 Missing ⚠️
frontend/src/lib/stores/userStore.svelte.ts 0.00% 34 Missing and 1 partial ⚠️
frontend/src/lib/components/UserDataInput.svelte 0.00% 29 Missing ⚠️
...end/src/lib/components/ChildrenRegistration.svelte 0.00% 24 Missing ⚠️
frontend/src/lib/components/ChildrenGallery.svelte 0.00% 20 Missing ⚠️
...c/lib/components/DataDisplay/GalleryDisplay.svelte 0.00% 19 Missing and 1 partial ⚠️
...ontend/src/lib/components/MilestoneOverview.svelte 0.00% 19 Missing ⚠️
frontend/src/lib/components/UserLogin.svelte 0.00% 15 Missing and 1 partial ⚠️
frontend/src/lib/components/UserProfile.svelte 0.00% 11 Missing and 1 partial ⚠️
... and 26 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   31.32%   29.99%   -1.33%     
==========================================
  Files         101       99       -2     
  Lines        3339     3247      -92     
  Branches       94       87       -7     
==========================================
- Hits         1046      974      -72     
+ Misses       2221     2201      -20     
  Partials       72       72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaHaWo MaHaWo requested a review from lkeegan November 15, 2024 13:25
lkeegan
lkeegan approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup job, thanks! some minor suggestions

frontend/src/lib/components/ChildrenRegistration.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/MilestoneButton.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/MilestoneGroup.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/UserLandingPage.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/UserLogin.svelte Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Nov 15, 2024

thanks for the hints. will merge when ready.

@MaHaWo MaHaWo merged commit a7a1597 into main Nov 15, 2024
6 checks passed
@MaHaWo MaHaWo deleted the 160-fix-user-login branch November 15, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkeegan lkeegan lkeegan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix User login component, usage frontend code quality
3 participants
@MaHaWo @codecov-commenter @lkeegan