Limit allowed file size to 2MB for image uploads #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lkeegan
commented
Nov 20, 2024
lkeegan
commented
- admin-frontend
- limit upload image file sizes to 2 MB for Milestone and MilestoneGroup images
- display warning modal and ignore files if too large
- limit upload image file sizes to 2 MB for Milestone and MilestoneGroup images
- frontend
- add WarningModal and ImageFileUpload components
- deployment
- set client_max_body_size to 2MB in nginx config
- backend
- remove exif orientation tag if present to avoid unexpected rotation of uploaded images in some cases
- use ImageOps.contain instead of resizing the image
- resolves Image upload file size limits #165
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 30.04% 29.96% -0.08%
==========================================
Files 99 101 +2
Lines 3245 3267 +22
Branches 87 89 +2
==========================================
+ Hits 975 979 +4
- Misses 2198 2214 +16
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
- admin-frontend
- limit upload image file sizes to 2 MB for Milestone and MilestoneGroup images
- display warning modal and ignore files if too large
- frontend
- add WarningModal and ImageFileUpload components
- deployment
- set client_max_body_size to 2MB in nginx config
- backend
- remove exif orientation tag if present to avoid unexpected rotation of uploaded images in some cases
- use ImageOps.contain instead of resizing the image
- resolves #165
lkeegan
force-pushed
the
fix_165_image_upload_file_size_limit
branch
from
0d7743c to
f9cbeb6
Compare
MaHaWo
approved these changes
Nov 21, 2024
…en the child WarningModal is closed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.