Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the alignment of elements on the front page #179

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Majapur1
Copy link
Collaborator

  • Changes the alignment of elements on devices with different screen sizes

@Majapur1 Majapur1 added javascript Pull requests that update Javascript code frontend labels Nov 20, 2024
@Majapur1 Majapur1 self-assigned this Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.04%. Comparing base (d7717bd) to head (9ca59cf).

Files with missing lines Patch % Lines
frontend/src/lib/components/FrontPageAbout.svelte 0.00% 2 Missing ⚠️
frontend/src/lib/components/FrontPageCard.svelte 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   30.04%   30.04%           
=======================================
  Files          99       99           
  Lines        3245     3245           
  Branches       87       87           
=======================================
  Hits          975      975           
  Misses       2198     2198           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, otherwise lgtm

frontend/src/lib/components/FrontPageAbout.svelte Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 20, 2024

@lkeegan lkeegan merged commit 6fed147 into main Nov 20, 2024
6 checks passed
@lkeegan lkeegan deleted the frontpage-alignment-fix branch November 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants