Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to submit milestone images #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Nov 22, 2024

  • backend
    • add SubmittedMilestoneImage to models
    • add /submitted-milestone-images post endpoint for users
    • add admin endpoints to get, approve and delete submitted images
  • frontend
    • button to Milestone component for user to upload an image
    • add SubmitMilestoneImageModal
      • with a checkbox for user to agree to conditions before submitting the image
  • admin-frontend
    • add tab with submitted images for review (accept / delete)
    • add text prop to SaveButton component
  • resolves Multiple images for milestones #50

- backend
  - add SubmittedMilestoneImage to models
  - add /submitted-milestone-images post endpoint for users
  - add admin endpoints to get, approve and delete submitted images
- frontend
  - button to Milestone component for user to upload an image
  - add SubmitMilestoneImageModal
    - with a checkbox for user to agree to conditions before submitting the image
- admin-frontend
  - add tab with submitted images for review (accept / delete)
  - add text prop to SaveButton component
- resolves #50
Copy link

sonarcloud bot commented Nov 22, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 35.93750% with 82 lines in your changes missing coverage. Please review.

Project coverage is 30.23%. Comparing base (d5bc9e6) to head (ff2e94b).

Files with missing lines Patch % Lines
...b/components/Admin/SubmittedMilestoneImages.svelte 0.00% 43 Missing and 1 partial ⚠️
...ponents/DataInput/SubmitMilestoneImageModal.svelte 0.00% 21 Missing and 1 partial ⚠️
frontend/src/lib/components/Milestone.svelte 0.00% 8 Missing ⚠️
...rontend/src/lib/components/Admin/SaveButton.svelte 0.00% 3 Missing and 1 partial ⚠️
frontend/src/lib/components/Admin/Languages.svelte 0.00% 1 Missing ⚠️
frontend/src/lib/components/Admin/Questions.svelte 0.00% 1 Missing ⚠️
frontend/src/lib/components/Admin/Users.svelte 0.00% 1 Missing ⚠️
frontend/src/lib/components/AdminPage.svelte 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   29.96%   30.23%   +0.26%     
==========================================
  Files         101      103       +2     
  Lines        3267     3390     +123     
  Branches       89       91       +2     
==========================================
+ Hits          979     1025      +46     
- Misses       2214     2289      +75     
- Partials       74       76       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lkeegan lkeegan requested a review from MaHaWo November 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple images for milestones
2 participants