Add carousel with news items to front page #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lkeegan
commented
Nov 6, 2024
lkeegan
commented
- news items displayed in carousel which scrolls every 3 seconds
- clicking on an item opens the associated url in a new window
- news items are stored in the file src/assets/news.json for now
- could make it editable from the admin interface in the future
- uses vueperslides library
- resolves Banner #37
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 8 8
Lines 713 713
=======================================
Hits 556 556
Misses 157 157 ☔ View full report in Codecov by Sentry. |
lkeegan
force-pushed
the
fix_37_add_carousel_to_front_page
branch
from
345174d
to
764695f
Compare
- news items displayed in carousel which scrolls every 3 seconds - clicking on an item opens the associated url in a new window - news items are stored in the file src/assets/news.json for now - could make it editable from the admin interface in the future - uses vueperslides library - add vuesperslides.d.ts as the library has no typescript support - resolves #37
lkeegan
force-pushed
the
fix_37_add_carousel_to_front_page
branch
from
764695f
to
e4cfd88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.