Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove docker package installation #1877

Merged
merged 1 commit into from
Jan 17, 2025
Merged

ci: remove docker package installation #1877

merged 1 commit into from
Jan 17, 2025

Conversation

phbelitz
Copy link
Member

@phbelitz phbelitz commented Jan 17, 2025

The docker package is already installed in the ubunutu version of github runners and thus doesn't need to be installed. Also the package no longer is available in the default apt repositories anyways.

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

The docker package is already installed in the ubunutu version of github runners and thus doesn't need to be installed. Also the package no longer is available in the default apt repositories anyways.
@phbelitz phbelitz changed the title ci: use official docker package ci: remove docker package installation Jan 17, 2025
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@phbelitz phbelitz merged commit 22c1c5d into develop Jan 17, 2025
39 checks passed
@phbelitz phbelitz deleted the ci/fix/shn-docker branch January 17, 2025 10:14
@phbelitz phbelitz mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants