Enable Pointer Returns in C++ #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwatts
added
enhancement
ponyisi
reviewed
Apr 8, 2025
| @@ -8,7 +8,7 @@ packages = [{ include = "code_generator_funcadl_xaod" }] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "~3.10" | |||
| func-adl-xAOD = "2.2.0" | |||
| func-adl-xAOD = "^2.2.0" | |||
There was a problem hiding this comment.
I'm a bit confused here - doesn't this syntax allow 2.2.0 to be used? Don't you actually want ^2.2.1 ? (or >=2.2.1)
BenGalewsky
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of
func_adl_xAODenables C++ pointers to be returned from injected C++ code.This is especially helpful when dealing with ElementLink's that have to by dynamically cast to other object types (knarly, dude).
This is suitable for inclusing in a release as soon as it has passed review and tests.