Check and return errors while validating science image. #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #555 +/- ##
===========================================
+ Coverage 92.72% 95.55% +2.83%
===========================================
Files 80 28 -52
Lines 2309 720 -1589
Branches 154 7 -147
===========================================
- Hits 2141 688 -1453
+ Misses 143 28 -115
+ Partials 25 4 -21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540.
This PR is not ready to be merged yet. The code works but tests need to be changed as well. How ever, I am running into issues while running tests. Firstly, the test instructions in "README" don't work as there is no "setup.py" in "servicex_app" directory. I managed to install all dependencies explicitly but some tests keep failing even in develop branch. It will be great if someone can tell me if the tests are maintained and if they are expected to succeed.
I manually tested the change by using the science image "sslhep/sslhep/servicex_code_gen_func_adl_uproot" and the request fails (as expected) with this error: