Style fixes #643
Merged
Style fixes #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiux
cmkohnen
reviewed
Dec 12, 2023
src/styles.py
Outdated
Comment on lines
617
to
629
| style_manager = self._style_manager | ||
| style_model = style_manager.props.style_model | ||
| file = self.style.get_file() | ||
| for index, style in enumerate(style_model): | ||
| if style is not None: | ||
| file2 = style.get_file() | ||
| if file2 is not None and file.equal(file2): | ||
| stylename = style.get_name() | ||
| style_model.remove(index) | ||
| style_manager._stylenames.remove(stylename) | ||
| style_manager.props.use_custom_style = False | ||
| style_manager.props.custom_style = \ | ||
| style_manager._system_style_name |
There was a problem hiding this comment.
This logic is making a few calls, that should rather be in the stylemanager itself imo.
add return type
sstendahl
force-pushed
the
Styles-fixes
branch
from
30ddd35 to
d524235
Compare
cmkohnen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with the styles:
Stops connecting style preview buttons to
window.edit_styleafter the initial time. This prevents multiple calls to the same functions which lead to performance issues, and "critical" errors in the terminal output about the view already being present in the stack.Reorders a bit with regard to the behaviour on style changes/edits. Allows to edit the current style, and then keep this style selecting (and applying changes) when backing out.
New styles now use the currently active style as template by default, instead of the top style.
I've also looked into why the scroll window has such an incredibly long list of whitespace. The cause of this is that it reserves whitespace for when the window is resized to fewer columns. So the reserved amount of space is equal to the amount of space that is needed for the case when there's only one column present per row. Not completely sure if it's fixable.