Do not optimise limits for hidden items #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not optimise limits for items that are hidden.
cmkohnen
reviewed
Jan 17, 2024
src/data.py
Outdated
| if not isinstance(item_, item.DataItem): | ||
| if not isinstance(item_, item.DataItem) or ( | ||
| not item_.get_selected() | ||
| and figure_settings.get_property("hide-unselected")): |
There was a problem hiding this comment.
This could use the direct call of get_hide_unselected()
cmkohnen
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not optimise limits for items that are hidden. I found it unintuitive if items are hidden, that these are still taken into account when doing optimise limits. Skipping those items make the following possible:
Skarminspelning.fran.2024-01-17.08-17-17.webm
Which is thus useful if you have a bunch of datasets in the same project with different limits, and just want to toggle between them. When items are not hidden, but non-active, then they are still used when optimising the limits.