Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interchain adapters #75

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Interchain adapters #75

merged 3 commits into from
Dec 18, 2023

Conversation

iammrjude
Copy link
Member

No description provided.

Comment on lines +52 to +58
function estimateFee(
uint16 _dstChainId,
bool _useZro,
bytes calldata _adapterParams
) public view returns (uint nativeFee, uint zroFee) {
return lzEndpoint.estimateFees(_dstChainId, address(this), PAYLOAD, _useZro, _adapterParams);
}
Comment on lines +60 to +66
function getOracle(uint16 remoteChainId) external view returns (address _oracle) {
bytes memory bytesOracle =
lzEndpoint.getConfig(lzEndpoint.getSendVersion(address(this)), remoteChainId, address(this), 6);
assembly {
_oracle := mload(add(bytesOracle, 32))
}
}

Check warning

Code scanning / Slither

Assembly usage Warning

/* INITIALIZATION */
/*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

function initialize(address platform_, address _lzEndpoint) external initializer {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning


function estimateFee(
uint16 _dstChainId,
bool _useZro,

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

function endpoint() external view returns (address) {}

function estimateFee(
uint16 _dstChainId,

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

function estimateFee(
uint16 _dstChainId,
bool _useZro,
bytes calldata _adapterParams

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fa307b9) 84.43% compared to head (82e3e97) 84.63%.

Files Patch % Lines
src/adapters/LayerZeroInterChainAdapter.sol 0.00% 10 Missing ⚠️
src/bridge/Bridge.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           7-bridge-sc      #75      +/-   ##
===============================================
+ Coverage        84.43%   84.63%   +0.19%     
===============================================
  Files               53       54       +1     
  Lines             3489     3481       -8     
  Branches           446      442       -4     
===============================================
  Hits              2946     2946              
+ Misses             394      386       -8     
  Partials           149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a17 a17 merged commit 3e18d86 into 7-bridge-sc Dec 18, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants