Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save gas for ops. amount = 0 (SlowMist N4) #140

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Save gas for ops. amount = 0 (SlowMist N4) #140

merged 2 commits into from
Nov 16, 2023

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Nov 7, 2023

Description

Slowmist problem description:

Amount should be greater than zero, a parameter of zero is waste of gas.

Our response:

Suggested changes applied.

Types of changes

What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

deblanco
deblanco previously approved these changes Nov 9, 2023
@deblanco deblanco dismissed stale reviews from GabrielMartinezRodriguez and themself via fb690e0 November 15, 2023 21:40
@deblanco deblanco merged commit 0d7b515 into main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants