Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panicking error to unimplemented (SlowMist N8) #142

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Nov 7, 2023

Description

SlowMist during its audit reported:

If EVM calls make_free_balance_be , the node crashes.

fn make_free_balance_be(
  _who: &T::AccountId,
  _balance: Self::Balance,
) -> SignedImbalance<Self::Balance, Self::PositiveImbalance> {
  panic!("make_free_balance_be is not allowed in this pallet")
}

Response:

Panic call has been removed and implemented a mock function as well as for the rest of this trait. The reason why this trait is mocked is in this issue

Types of changes

What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@deblanco deblanco merged commit fbe2ae8 into main Nov 16, 2023
@deblanco deblanco deleted the chore-panicking-function branch November 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants