Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call tracer for debug_traceTransaction #169

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Fix call tracer for debug_traceTransaction #169

merged 4 commits into from
Feb 14, 2024

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Feb 13, 2024

Description

The usage of the Runner for determining the transactions' conversion rate leads to create an additional entry in the transaction trace, and due to the implementation of moonbeam's evm-tracer was throwing an error.

The solution is straightforward: filter out the additional entry provoked by the call to ConversionRateController

Types of changes

What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@deblanco deblanco merged commit 6bb0508 into main Feb 14, 2024
1 check passed
@deblanco deblanco deleted the fix-call-tracer branch February 14, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants