Make sure that get_items does not recurse (#608)

Since we were ignoring the `recursive` argument, you could enter a recursion loop

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+- Recursion error in `get_items` [#608](https://github.com/stac-utils/pystac-client/pull/608)
+
 ## [v0.7.5] - 2023-09-05
 
 ### Fixed

pystac_client/client.py

@@ -438,12 +438,14 @@ def get_collections(self) -> Iterator[Collection]:
                 call_modifier(self.modifier, collection)
                 yield collection
 
-    def get_items(self, *ids: str, recursive: bool = False) -> Iterator["Item_Type"]:
+    def get_items(
+        self, *ids: str, recursive: Optional[bool] = None
+    ) -> Iterator["Item_Type"]:
         """Return all items of this catalog.
 
         Args:
             ids: Zero or more item ids to find.
-            recursive: unused
+            recursive: unused in pystac-client, but needed for falling back to pystac
 
         Return:
             Iterator[Item]: Iterator of items whose parent is this
@@ -454,7 +456,9 @@ def get_items(self, *ids: str, recursive: bool = False) -> Iterator["Item_Type"]
             yield from search.items()
         else:
             self._warn_about_fallback("ITEM_SEARCH")
-            for item in super().get_items(*ids, recursive=True):
+            for item in super().get_items(
+                *ids, recursive=recursive is None or recursive
+            ):
                 call_modifier(self.modifier, item)
                 yield item