Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to CLI error messages #531

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 7, 2023

Related Issue(s):

Description:

Here's the error message with pystac==1.7.3:

$ stac-client collections landing-page-with-invalid-collection.json
ERROR: JSON does not represent a STAC object.
The client at /Users/gadomski/Code/stac-utils/pystac-client/tests/data/landing-page-with-invalid-collection.json is OK, but one or more of the collections is invalid.

And with pystac at main (soon to be v1.8):

$ stac-client collections tests/data/landing-page-with-invalid-collection.json
ERROR: JSON (id = invalid-collection) does not represent a STACObject instance. 'type' attribute is collection
The client at /Users/gadomski/Code/stac-utils/pystac-client/tests/data/landing-page-with-invalid-collection.json is OK, but one or more of the collections is invalid.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski added this to the 0.7.0 milestone Jun 7, 2023
@gadomski gadomski requested a review from ircwaves June 7, 2023 15:56
@gadomski gadomski self-assigned this Jun 7, 2023
@gadomski gadomski enabled auto-merge (squash) June 7, 2023 16:06
@gadomski gadomski merged commit 3dd14fd into main Jun 7, 2023
@gadomski gadomski deleted the issues/130-error-messages branch June 7, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-to-understand error messages from the CLI
2 participants