Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update STAC_VERSION to v1.1.0 #1427

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update STAC_VERSION to v1.1.0 #1427

merged 2 commits into from
Oct 7, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 6, 2024

Related Issue(s):

Description:

This PR updates STAC_VERSION, switches the local json-schema files to v1.1.0, and updates all test files to v1.1.0. There was one test change required because two-element bboxes are no longer allowed in Collections (radiantearth/stac-spec#1243). Otherwise, there's no code changes.

I didn't expect to want to do this change so early, but it didn't make much sense to start doing v1.1 things (e.g. #1377) while we were still writing STAC v1.0.0.

I don't think this is breaking, as the API doesn't change, but other opinions are available.

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the v1.12 milestone Oct 6, 2024
@gadomski gadomski requested a review from jsignell October 6, 2024 18:02
@gadomski gadomski self-assigned this Oct 6, 2024
@gadomski gadomski mentioned this pull request Oct 6, 2024
13 tasks
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (d3630e6) to head (1bf4575).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          52       52           
  Lines        7237     7237           
  Branches     1018     1018           
=======================================
  Hits         6601     6601           
  Misses        457      457           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell
Copy link
Member

jsignell commented Oct 7, 2024

So pystac output is already valid for STAC spec 1.1?

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's valid then yeah sounds good!!

@gadomski gadomski added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 1899823 Oct 7, 2024
20 checks passed
@gadomski gadomski deleted the stac-v1.1 branch October 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants