add advanced setting for enabling plain HTTP domains #403

TheCactusBlue · 2025-01-28T17:18:36Z

Important

Add support for enabling plain HTTP domains for development in domain configuration and validation.

Behavior:
- Added allowInsecureHttp boolean to domain configuration in page-client.tsx.
- Updated domain validation to allow HTTP if allowInsecureHttp is true.
- Added UI switch for enabling HTTP domains in EditDialog.
Validation:
- Removed projectTrustedDomainSchema and updated domainSchema to allow HTTP.
Tests:
- Added test cases in projects.test.ts for allowing HTTP domains and rejecting non-HTTP protocols.

^{This description was created by}^{for 735fba1. It will automatically update as commits are pushed.}

vercel · 2025-01-28T17:18:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stack-backend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 6:17am
stack-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 6:17am
stack-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 6:17am

CLAassistant · 2025-01-28T17:18:44Z

All committers have signed the CLA.

fomalhautb

Looks good to me other than the few comments

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx

.github/workflows/setup-tests.yaml

packages/stack-shared/src/interface/crud/projects.ts

N2D4

Some comments below. btw when doing UI changes, add a screenshot of the new UI for the reviewers

packages/stack-shared/src/interface/crud/projects.ts

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx

N2D4 · 2025-01-29T18:05:54Z

also, can you add an E2E test for this?

apps/backend/src/generated/api-versions.json

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx

ellipsis-dev · 2025-02-06T20:01:48Z

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx

-      .transform((value) => 'https://' + value)
+    domain: yup.string()
+      .matches(DOMAIN_REGEX, "Invalid domain")
+      .test('is-domain', (domain) => {


The custom Yup test always uses 'https://' when calling createUrlIfValid. Consider referencing the allowInsecureHttp flag (via this.parent) so that if plain HTTP is enabled, the proper protocol is validated. Also consider adding an explicit error message for clarity.

N2D4 · 2025-02-09T23:16:26Z

@TheCactusBlue can you add E2E tests, and then merge this?

ellipsis-dev · 2025-02-10T06:16:01Z

apps/e2e/tests/backend/endpoints/api/v1/projects.test.ts

+  `);
+});
+
+it("should not allow protocols other than http(s) in trusted domains", async ({ expect }) => {


The test description 'should not allow protocols other than http(s)' is inconsistent with the inline snapshot which still returns status 200 and includes the 'whatever://' protocol. Please verify if disallowed protocols should result in an error response.

TheCactusBlue added 5 commits January 28, 2025 17:19

add setup tests

29e1fdc

continue, even on error

ecf98d9

http domains

4325613

integrate it into the form

5c9f936

some server work as well

0a992c2

TheCactusBlue force-pushed the http-domains branch from a75a5d6 to 0a992c2 Compare January 28, 2025 17:19

vercel bot deployed to Preview – stack-demo January 28, 2025 17:24 View deployment

vercel bot deployed to Preview – stack-backend January 28, 2025 17:25 View deployment

vercel bot deployed to Preview – stack-dashboard January 28, 2025 17:27 View deployment

fomalhautb reviewed Jan 29, 2025

View reviewed changes

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx Outdated Show resolved Hide resolved

.github/workflows/setup-tests.yaml Outdated Show resolved Hide resolved

packages/stack-shared/src/interface/crud/projects.ts Show resolved Hide resolved

N2D4 added 2 commits January 29, 2025 09:57

Delete .github/workflows/setup-tests.yaml

41b77e4

Merge branch 'dev' into http-domains

9910837

vercel bot deployed to Preview – stack-backend January 29, 2025 18:02 View deployment

vercel bot deployed to Preview – stack-demo January 29, 2025 18:02 View deployment

vercel bot deployed to Preview – stack-dashboard January 29, 2025 18:03 View deployment

N2D4 requested changes Jan 29, 2025

View reviewed changes

packages/stack-shared/src/interface/crud/projects.ts Outdated Show resolved Hide resolved

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx Outdated Show resolved Hide resolved

Merge branch 'dev' into http-domains

b992668

vercel bot deployed to Preview – stack-demo February 2, 2025 02:08 View deployment

vercel bot deployed to Preview – stack-backend February 2, 2025 02:12 View deployment

vercel bot deployed to Preview – stack-dashboard February 2, 2025 02:13 View deployment

Merge branch 'dev' into http-domains

3c79e0e

vercel bot deployed to Preview – stack-backend February 6, 2025 01:44 View deployment

vercel bot deployed to Preview – stack-demo February 6, 2025 01:46 View deployment

vercel bot deployed to Preview – stack-dashboard February 6, 2025 01:48 View deployment

resolve more

d47144e

vercel bot deployed to Preview – stack-demo February 6, 2025 19:38 View deployment

vercel bot deployed to Preview – stack-backend February 6, 2025 19:38 View deployment

vercel bot deployed to Preview – stack-dashboard February 6, 2025 19:41 View deployment

N2D4 added 2 commits February 6, 2025 11:41

Delete apps/backend/src/generated/api-versions.json

d41bb2b

Delete apps/backend/src/generated/routes.json

f27b01b

N2D4 requested changes Feb 6, 2025

View reviewed changes

apps/backend/src/generated/api-versions.json Outdated Show resolved Hide resolved

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/domains/page-client.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – stack-backend February 6, 2025 19:45 View deployment

vercel bot deployed to Preview – stack-demo February 6, 2025 19:47 View deployment

vercel bot deployed to Preview – stack-dashboard February 6, 2025 19:50 View deployment

TheCactusBlue added 2 commits February 6, 2025 19:59

apply

3da1caa

fix domain validation

03fa346

ellipsis-dev bot reviewed Feb 6, 2025

View reviewed changes

vercel bot deployed to Preview – stack-demo February 6, 2025 20:04 View deployment

vercel bot deployed to Preview – stack-backend February 6, 2025 20:05 View deployment

vercel bot deployed to Preview – stack-dashboard February 6, 2025 20:07 View deployment

N2D4 approved these changes Feb 6, 2025

View reviewed changes

add test cases

735fba1

ellipsis-dev bot reviewed Feb 10, 2025

View reviewed changes

vercel bot deployed to Preview – stack-demo February 10, 2025 06:16 View deployment

vercel bot deployed to Preview – stack-backend February 10, 2025 06:17 View deployment

vercel bot deployed to Preview – stack-dashboard February 10, 2025 06:17 View deployment

fomalhautb merged commit 064b522 into dev Feb 10, 2025
13 of 15 checks passed

fomalhautb deleted the http-domains branch February 10, 2025 18:07

TheCactusBlue added a commit that referenced this pull request Feb 11, 2025

fix tests from PR #403

9a25336

TheCactusBlue added a commit that referenced this pull request Feb 11, 2025

fix tests from PR #403 (#427)

b28eadb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add advanced setting for enabling plain HTTP domains #403

add advanced setting for enabling plain HTTP domains #403

TheCactusBlue commented Jan 28, 2025 •

edited by ellipsis-dev bot

Loading

vercel bot commented Jan 28, 2025 •

edited

Loading

CLAassistant commented Jan 28, 2025 •

edited

Loading

fomalhautb left a comment

N2D4 left a comment

N2D4 commented Jan 29, 2025

ellipsis-dev bot Feb 6, 2025

N2D4 commented Feb 9, 2025

ellipsis-dev bot Feb 10, 2025

add advanced setting for enabling plain HTTP domains #403

add advanced setting for enabling plain HTTP domains #403

Conversation

TheCactusBlue commented Jan 28, 2025 • edited by ellipsis-dev bot Loading

vercel bot commented Jan 28, 2025 • edited Loading

CLAassistant commented Jan 28, 2025 • edited Loading

fomalhautb left a comment

Choose a reason for hiding this comment

N2D4 left a comment

Choose a reason for hiding this comment

N2D4 commented Jan 29, 2025

ellipsis-dev bot Feb 6, 2025

Choose a reason for hiding this comment

N2D4 commented Feb 9, 2025

ellipsis-dev bot Feb 10, 2025

Choose a reason for hiding this comment

TheCactusBlue commented Jan 28, 2025 •

edited by ellipsis-dev bot

Loading

vercel bot commented Jan 28, 2025 •

edited

Loading

CLAassistant commented Jan 28, 2025 •

edited

Loading