-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pybinding task actuation equality #234
base: devel
Are you sure you want to change the base?
Pybinding task actuation equality #234
Conversation
Hi ! This project doesn't usually accept pull requests on the main branch. |
Hi @andreadelprete, Thanks for the reply. I have no idea how it happened. But, I can certainly double check from side and fix the issue. Thank you and have a good one :) |
Hi @andreadelprete , I had a look at the issue. I think the problem is, I have created a new branch from master which already includes changes/PR from the @egordv as shown in the figure I believe these changes from @egordv are missing from the devel branch. When I was submitting my PR initially to merge with master branch. I have received a warning that i should merge my changes with devel branch instead of master. So, I have changed my PR to merge with devel. One way of fixing this is to merge my changes to master directly. But, I am not sure whether I can do that as I received a warning earlier. I really appreciate it if you can tell me how to proceed. Thank you. |
I merged master into devel, so this commit is now in devel. Can you now rebase your PR on the current devel, @rua0ra1 ? |
Hi @nim65s , I tried to do it. But, i can't see the update branch option to rebase. |
84f401b
to
91af876
Compare
for more information, see https://pre-commit.ci
91af876
to
1a59d53
Compare
for more information, see https://pre-commit.ci
Ok, this should be good now. |
Hi @andreadelprete,
As discussed in the #233 . I have implemented the python bindings for TaskActuationEquality by following the examples from other bindings. Please have a look and let me know your suggestions and feedback. Thank you and have a nice day :)