Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hbase reduce image size #1028

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Mar 14, 2025

Description

part of #961

REPOSITORY                              TAG                                   IMAGE ID       CREATED         SIZE
oci.stackable.tech/sdp/hbase            2.6.1-stackable25.3.0-reduced-size    6156042ef58b   5 minutes ago   1.76GB
oci.stackable.tech/sdp/hbase            2.6.1-stackable25.3.0                 7f463d69a327   2 days ago      2.62GB
  • Remove chowns from final image (done in copy)
  • Remove chmod from final image (done in each builder)
  • Uses check-permissions-ownership script to validate any wrong permissions / ownership in the /stackable folder (example for nifi)
 => [nifi-2_2_0 final  7/10] RUN <<EOF (microdnf update...)                                                                                                                                         8.2s
 => ERROR [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...)                                                                                                         0.9s
------
 > [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...):
0.601 Ownership mismatch:  /stackable/nifi (Expected: 1000:0, Found: 0:0)
0.622 Permission mismatch: /stackable/python (Owner: rwx, Group: r-x)
0.624 Permission mismatch: /stackable/bin (Owner: rwx, Group: r-x)
0.628 Permission mismatch: /stackable/nifi-2.2.0 (Owner: rwx, Group: r-x)
0.843 Permission and Ownership checks failed for /stackable!


@maltesander maltesander marked this pull request as ready for review March 28, 2025 13:48
@maltesander maltesander self-assigned this Mar 28, 2025
@siegfriedweber siegfriedweber self-requested a review April 4, 2025 12:03
@@ -44,7 +44,7 @@ RUN --mount=type=cache,id=maven-hbase-${PRODUCT},uid=${STACKABLE_USER_UID},targe
###
### HBase
###
curl "https://repo.stackable.tech/repository/packages/hbase/hbase-${PRODUCT}-src.tar.gz" | tar -xzC .
curl --fail "https://repo.stackable.tech/repository/packages/hbase/hbase-${PRODUCT}-src.tar.gz" | tar -xzC .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stackable-base image contains a .curlrc file where sensible defaults like --fail are already set:

# Fail the request if the server returns an error (4xx or 5xx HTTP status code)
# https://everything.curl.dev/http/response.html#http-response-codes
fail

Suggested change
curl --fail "https://repo.stackable.tech/repository/packages/hbase/hbase-${PRODUCT}-src.tar.gz" | tar -xzC .
curl "https://repo.stackable.tech/repository/packages/hbase/hbase-${PRODUCT}-src.tar.gz" | tar -xzC .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

3 participants