Skip to content

Commit

Permalink
fix(stackable-telemetry): disable export of h2 events via OTLP
Browse files Browse the repository at this point in the history
It causes infinite cascading events to be emitted. See open-telemetry/opentelemetry-rust#761
  • Loading branch information
NickLarsenNZ committed May 24, 2024
1 parent 3548b01 commit d7bde99
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions crates/stackable-telemetry/src/tracing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ impl Tracing {
if self.otlp_log_config.enabled {
let env_filter_layer = EnvFilter::builder()
.with_default_directive(self.otlp_log_config.level_filter.into()) // TODO (@NickLarsenNZ): support Directives
.from_env_lossy();
.from_env_lossy()
// TODO (@NickLarsenNZ): Remove this directive once https://github.com/open-telemetry/opentelemetry-rust/issues/761 is resolved
.add_directive("h2=off".parse().expect("invalid directive"));

let log_exporter = opentelemetry_otlp::new_exporter().tonic();
let otel_log =
Expand All @@ -173,13 +175,9 @@ impl Tracing {
if self.otlp_trace_config.enabled {
let env_filter_layer = EnvFilter::builder()
.with_default_directive(self.otlp_trace_config.level_filter.into()) // TODO (@NickLarsenNZ): support Directives
.from_env_lossy();
// .add_directive("hyper=info".parse().expect("invalid directive"))
// .add_directive("tonic=warn".parse().expect("invalid directive"))
// .add_directive("tokio_util=warn".parse().expect("invalid directive"))
// .add_directive("hyper=info".parse().expect("invalid directive"))
// .add_directive("h2=info".parse().expect("invalid directive"))
// .add_directive("tower=info".parse().expect("invalid directive"));
.from_env_lossy()
// TODO (@NickLarsenNZ): Remove this directive once https://github.com/open-telemetry/opentelemetry-rust/issues/761 is resolved
.add_directive("h2=off".parse().expect("invalid directive"));

let trace_exporter = opentelemetry_otlp::new_exporter().tonic();
let otel_tracer = opentelemetry_otlp::new_pipeline()
Expand Down

0 comments on commit d7bde99

Please sign in to comment.