Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): Exclude template block grammars in CSS and JS contexts #10

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix(angular): Exclude template block grammars in CSS and JS contexts #10

merged 1 commit into from
Jul 3, 2024

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Dec 6, 2023

This commit ensures the Angular template block syntax highlighting does not apply in in the HTML language where it has transitioned to embedded css or js (i.e. in script tags).

@atscott
fix(angular): Exclude template block grammars in CSS and JS contexts
ea306d6 
This commit ensures the Angular template block syntax highlighting does
not apply in in the HTML language where it has transitioned to embedded
`css` or `js` (i.e. in `script` tags).
SamVerschueren
SamVerschueren approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙏 ! Noticed that it was changed upstream as well.

@SamVerschueren SamVerschueren merged commit 62007a4 into stackblitz:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamVerschueren SamVerschueren SamVerschueren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atscott @SamVerschueren