Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #1315
TODO:
phoenixd
and test againstI will probably test the API calls on mainnet since
phoenixd
doesn't support signet yet (ACINQ/phoenixd#49)Additional Context
genwallet
script that generates some boilerplate code. It also marks the lines of code that require updates with TODOs that are easily searchable.phoenixd
only supportsmainnet
andtestnet
:Checklist
Are your changes backwards compatible? Please answer below:
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
I'd give this a 6.
I have setup
phoenixd
on a server (phoenixd.ekzy.is). The code is able to pay invoices and create invoices. I tested the payment with a mainnet invoice. I also added code to handle any errors I encountered i.e. payment failures.phoenixd
seems to mainly report errors as a text. An example is visiting / of phoenixd.ekzy.is which responds withUnknown endpoint (check api doc)
. However, on payment failures, it might also respond with success (2xx status code) but not contain a preimage but a reason.Therefore, there might be more errors I am not properly handling so might result in a ugly toast but I think this is not blocking or wait until we can run
phoenixd
on regtest for proper integration testing.For frontend changes: Tested on mobile? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here: