Fix bug with first draw call #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attribute locations aren't correct on the first draw call, because the shader is bound in `GLGeometry.prototype.bind` before they are updated and `gl-shader` updates locations when it is bound. Binding the shader after the attributes are updated fixes the problem. This fixes issue stackgl/gl-shader#5.
|
Good catch, thanks very much @abiro! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute locations aren't correct on the first draw call, because
the shader is bound in
GLGeometry.prototype.bindbefore they areupdated and
gl-shaderupdates locations when it is bound. Binding theshader after the attributes are updated fixes the problem.
This fixes issue stackgl/gl-shader#5.