Ensure on_end makes input tz aware and fix on_end method #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGarbutt
commented
Sep 13, 2024
coral_credits/api/views.py
Outdated
| return self._create_or_update( | ||
| request, current_lease_required=True, dry_run=False | ||
| request, | ||
| is_delete=True, |
There was a problem hiding this comment.
I should retest without this bit of the change, I think we do send the current lease.
There was a problem hiding this comment.
On-end from blazar just sends the lease parameter I believe, not current_lease like update does. However we do want to do an update on coral_credits side, so we should handle this
scrungus
changed the title
|
also adds a unit test to test deletion of current reservation |
added 3 commits
September 23, 2024 12:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.