-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rocky Linux 9.4 (Yoga) #1196
Open
m-bull
wants to merge
11
commits into
stackhpc/yoga
Choose a base branch
from
yoga-rl9.4
base: stackhpc/yoga
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cbab775)
(cherry picked from commit 5714737)
Substitute underscore in imagename for consistent formatting in whitelists file and remove unnecessary return code checking (cherry picked from commit f65f55b)
Remove CVE-2024-36039 from the Trivy whitelist and move to the example file setup to illustrate the global_allowed_vulnerabilities variable can be used to whitelist vulnerabilities in all images. (cherry picked from commit 8ed7e8a)
(cherry picked from commit 77172be)
By default the 'Run tempest' task has no_log set to avoid revealing sensitive data. This does not apply in CI, and makes it difficult to debug failures. (cherry picked from commit 8384dc4)
markgoddard
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks sensible. Needs testing in a multinode.
@m-bull Yoga is already outside of support, and I'm guessing this was tested in prod somewhere. Do you reckon it's reasonable to just get this merged? |
Alex-Welsh
added
enhancement
New feature or request
yoga
Targets the Yoga OpenStack release
labels
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.