Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning kolla, kolla-ansible and kayobe in caracal #1248

Open
wants to merge 1 commit into
base: stackhpc/2024.1
Choose a base branch
from

Conversation

darmach
Copy link
Member

@darmach darmach commented Aug 23, 2024

Pinned Kolla, Kolla-Ansible and Kayobe to tags - Caracal:

  • Kolla pinned to stackhpc/18.1.0.2
  • Kolla-Ansible pinned to stackhpc/18/1/0/2
  • Kayobe pinned to stackhpc/16.1.0.1

To be merged after @Alex-Welsh merges https://review.opendev.org/c/openstack/kolla-ansible/+/926618

Pinned Kolla, Kolla-Ansible and Kayobe to tags - Caracal:
 - Kolla pinned to stackhpc/18.1.0.2
 - Kolla-Ansible pinned to stackhpc/18/1/0/2
 - Kayobe pinned to stackhpc/16.1.0.1
@darmach darmach requested a review from a team as a code owner August 23, 2024 20:37
@bbezak
Copy link
Member

bbezak commented Aug 26, 2024

shouldn't we automate the pinning process? I don't think manual versions updating is a way to go

Comment on lines -148 to -151
# FIXME: Waiting for
# https://review.opendev.org/c/openstack/kolla-ansible/+/926198 to merge and
# sync to stackhpc/2024.1
# stackhpc_kolla_ansible_source_version: "stackhpc/{{ openstack_release }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stackhpc/kolla-ansible#596, available in stackhpc/18.1.0.4...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move these versions to a separate file to allow for easier automation. stackhpc-source-versions.yml?

@markgoddard
Copy link
Contributor

shouldn't we automate the pinning process? I don't think manual versions updating is a way to go

Agree, this is just the first step.

@Alex-Welsh
Copy link
Contributor

@darmach I think all the critical fixes are merged upstream now. We can merge this if you rebase & update the pins

@mnasiadka
Copy link
Member

Maybe we're a bit naive in here, who is going to pick up the burden of maintaining the pins before we get to an automated solution?

@Alex-Welsh
Copy link
Contributor

Maybe we're a bit naive in here, who is going to pick up the burden of maintaining the pins before we get to an automated solution?

Whoever needs the most recent changes probably

@mnasiadka
Copy link
Member

mnasiadka commented Sep 9, 2024

Maybe we're a bit naive in here, who is going to pick up the burden of maintaining the pins before we get to an automated solution?

Whoever needs the most recent changes probably

That's the naive part - who is going to watch for reasonable patches that come from upstream that would be beneficial to pull in? (especially security related patches).
One option is that it would be the same person approving PRs in Kayobe and Kolla-Ansible downstream forks - but would prefer an automated one (and @darmach has been so extremely fast with that one, that I don't know if we can put the burden of automating it on him) ;-)

@priteau priteau self-requested a review September 12, 2024 14:04
@Alex-Welsh
Copy link
Contributor

We should probably close this for now, since we decided to not pin anything until we can automate it

@Alex-Welsh Alex-Welsh added wontfix This will not be worked on Caracal Targets the Caracal OpenStack release labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caracal Targets the Caracal OpenStack release wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants