Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCA workflow support #1469

Open
wants to merge 13 commits into
base: stackhpc/2024.1
Choose a base branch
from
Open

DOCA workflow support #1469

wants to merge 13 commits into from

Conversation

assumptionsandg
Copy link
Contributor

@assumptionsandg assumptionsandg requested a review from a team as a code owner January 21, 2025 14:37
@product-auto-label product-auto-label bot added size: l ansible Ansible playbooks documentation Improvements or additions to documentation workflows Workflow files have been modified labels Jan 21, 2025
@Alex-Welsh
Copy link
Member

@assumptionsandg is this ready for review?

Comment on lines 202 to 208
kayobe seed host configure \
--skip-tags network,docker,docker-registry \
-e seed_bootstrap_user="cloud-user" \
-e controller_bootstrap_user="cloud-user" \
-e dnf_install_doca=true \
-e dnf_enable_doca_modules=false \
-e stackhpc_repos_enabled=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get these into the kayobe config rather than relying on extra vars.
If we can't add them to the builder env, what are your thoughts on adding a new doca-builder env which is dependent on the builder env? (see https://docs.openstack.org/kayobe/latest/multiple-environments.html#environment-dependencies) for more details on nested environments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using group vars for the ofed-builder however I think these were being overridden in stackhpc-ci.yml in the builder environment so that's why they're here.

It might be cleaner to create a ci-doca-builder environment though.

install-doca
------------

A playbook is provided to install DOCA on hosts in the `mlnx` group. Ensure this group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should define an empty group for this here: https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/2024.1/etc/kayobe/inventory/groups
Under "Feature control groups" imo

Pre-requisites
--------------

* Ensure the OFED hosts are upgraded with the latest packages in the point release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document the release train bit here? i.e. stackhpc_pulp_sync_ofed_modules: true, sync pulp, host configure, host package update.

@MoteHue
Copy link
Contributor

MoteHue commented Jan 30, 2025

The client side of this works, have tested in a prod system 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible playbooks documentation Improvements or additions to documentation size: l workflows Workflow files have been modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants