-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCA workflow support #1469
base: stackhpc/2024.1
Are you sure you want to change the base?
DOCA workflow support #1469
Conversation
@assumptionsandg is this ready for review? |
kayobe seed host configure \ | ||
--skip-tags network,docker,docker-registry \ | ||
-e seed_bootstrap_user="cloud-user" \ | ||
-e controller_bootstrap_user="cloud-user" \ | ||
-e dnf_install_doca=true \ | ||
-e dnf_enable_doca_modules=false \ | ||
-e stackhpc_repos_enabled=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to get these into the kayobe config rather than relying on extra vars.
If we can't add them to the builder env, what are your thoughts on adding a new doca-builder env which is dependent on the builder env? (see https://docs.openstack.org/kayobe/latest/multiple-environments.html#environment-dependencies) for more details on nested environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using group vars for the ofed-builder however I think these were being overridden in stackhpc-ci.yml in the builder environment so that's why they're here.
It might be cleaner to create a ci-doca-builder environment though.
f87435a
to
ed2ad6d
Compare
ed2ad6d
to
f66506c
Compare
3aa21d9
to
931e82c
Compare
install-doca | ||
------------ | ||
|
||
A playbook is provided to install DOCA on hosts in the `mlnx` group. Ensure this group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should define an empty group for this here: https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/2024.1/etc/kayobe/inventory/groups
Under "Feature control groups" imo
Pre-requisites | ||
-------------- | ||
|
||
* Ensure the OFED hosts are upgraded with the latest packages in the point release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document the release train bit here? i.e. stackhpc_pulp_sync_ofed_modules: true
, sync pulp, host configure, host package update.
The client side of this works, have tested in a prod system 👍 |
Latest configuration tested at UKHSA:
https://github.com/stackhpc/ukhsa-kayobe-config/commits/ukhsa-doca-deploy2