Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate releases with semantic-release in rag-template #7

Closed
wants to merge 5 commits into from

Conversation

nossi99
Copy link
Collaborator

@nossi99 nossi99 commented Jan 29, 2025

No description provided.

Copy link
Member

@a-klos a-klos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: remove the template from the pr text. write reasonable description if necessary.

run: npm clean-install
- name: Verify the integrity of provenance attestations and registry signatures for installed dependencies
run: npm audit signatures
- name: Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: more descriptive naming

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "lts/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: fix to specific version.

- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: checkout submodules. should be the latest version or the latest tag. but i think sometimes would be greate to have also chores etc checkedout. So better the latest version of main

@@ -0,0 +1,32 @@
name: Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: looks very clean, nice!

@a-klos a-klos closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants