Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement confirmation prompts #27

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Implement confirmation prompts #27

merged 6 commits into from
Nov 24, 2023

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Nov 24, 2023 •
edited
Loading

Added in all created/update/delete operations, plus ske enable/disable

@vicentepinto98
Copy link
Contributor

I would replace all Do you.... with Are you sure you....

vicentepinto98
vicentepinto98 reviewed Nov 24, 2023
View reviewed changes
internal/pkg/confirm/confirm.go Outdated Show resolved Hide resolved
internal/pkg/confirm/confirm_test.go Show resolved Hide resolved
internal/cmd/ske/enable/enable.go Outdated Show resolved Hide resolved
internal/cmd/ske/disable/disable.go Outdated Show resolved Hide resolved
@hcsa73 hcsa73 merged commit 5fa7923 into main Nov 24, 2023
1 check passed
@hcsa73 hcsa73 deleted the hs/confirmation-prompt-v2 branch November 24, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopalet joaopalet joaopalet left review comments

@vicentepinto98 vicentepinto98 vicentepinto98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcsa73 @vicentepinto98 @joaopalet