ROX-25218: Instruct Collector to not aggregate some subnets #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
reviewed
Jul 3, 2024
There was a problem hiding this comment.
As discussed offline, maybe non aggregated networks/address might be a better name to detailed networks/address. We can use a synonym or shorten the words when needed.
Other than that the PR looks good, think it's a good step forward for how we handle networks, just left a couple minor comments.
ovalenti
force-pushed
the
ovalenti/config_detailed_subnets
branch
from
4f9da10 to
dd6048e
Compare
ovalenti
changed the title
ovalenti
added a commit
that referenced
this pull request
Jul 10, 2024
ROX_NON_AGGREGATED_NETWORKS can list subnets that should not be aggregated. This is very similar to private network subnets.
Molter73
pushed a commit
that referenced
this pull request
Jul 24, 2024
ROX_NON_AGGREGATED_NETWORKS can list subnets that should not be aggregated. This is very similar to private network subnets.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an environment variable providing Collector with a list of subnets to never aggregate (
ROX_NON_AGGREGATED_NETWORKS).As a side effect, this can be used to expand the list of standard private network prefixes with new ones.
Checklist
Testing
central-dbROX_NON_AGGREGATED_NETWORKS=34.228.224.0/24centralconnecting tocentral-db