Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap parallelism of dependency building #2014

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Jan 21, 2025

Description

When building the third party dependencies, we use the nproc command to try and get as many parallel builds as possible running at once. This can bring problems on systems with large numbers of cores and not enough ram to come with them, so for those we provide the option of manually setting the number of parallel builds with an environment variable.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

  • Test the downstream build works as expected on affected systems.

When building the third party dependencies, we use the nproc command to
try and get as many parallel builds as possible running at once. This
can bring problems on systems with large numbers of cores and not enough
ram to come with them, so for those we provide the option of manually
setting the number of parallel builds with an environment variable.
@Molter73 Molter73 marked this pull request as ready for review January 21, 2025 13:52
@Molter73 Molter73 requested a review from a team as a code owner January 21, 2025 13:52
@Molter73 Molter73 requested a review from erthalion January 21, 2025 13:52
@Molter73 Molter73 merged commit 419ceb4 into master Jan 21, 2025
141 of 167 checks passed
@Molter73 Molter73 deleted the mauro/cap-builder-parallelism branch January 21, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants