-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-20252: add rosa hcp option #1053
Conversation
A single node development cluster (infra-pr-1053) was allocated in production infra for this PR. CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.7-18-g4a505fc3dc to it. 🔌 You can connect to this cluster with:
🛠️ And pull infractl from the deployed dev infra-server with:
🚲 You can then use the dev infra instance e.g.:
Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
LogsLogs for the development infra depending on your @redhat.com authuser: Or:
|
A single node development cluster (infra-pr-1053) was allocated in production infra for this PR. CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.8-124-ga20dcf86b2 to it. 🔌 You can connect to this cluster with:
🛠️ And pull infractl from the deployed dev infra-server with:
🚲 You can then use the dev infra instance e.g.:
Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
LogsLogs for the development infra depending on your @redhat.com authuser: Or:
|
- name: managed-cp | ||
description: Use managed control-plane? | ||
value: "false" | ||
kind: optional | ||
help: | | ||
Run as ROSA HCP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this parameter be exposed to the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure. I like showing that both ROSA flavors are the same, but with different default values. But it may just be confusing? I wondered if I should reset the ROSA flavor to be the same as it was before this change(?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it is confusing now, because you could set Use Managed Control Plane
to true
in classic ROSA - what would the effect be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, you can change the arguments in the rosa flavor form to match the defaults in the hcp/hypershift form and you'll get a matching cluster. So it just provides different default settings, and the managed_cp
toggles hypershift on/off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit/suggestion for help formatting, but otherwise LGTM.
Co-authored-by: Gavin Jefferies <[email protected]>
Adds flavor option to infra for ROSA HCP.