-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-27350: Setup ACS trusted tasks builds and publishing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a98d0a0
to
4056835
Compare
b798fe8
to
6921801
Compare
msugakov
added a commit
to stackrox/collector
that referenced
this pull request
Dec 12, 2024
1 task
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 12, 2024
which come from stackrox/konflux-tasks#3
4 tasks
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 12, 2024
which come from stackrox/konflux-tasks#3
9a6400e
to
1c67bf3
Compare
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 13, 2024
which come from stackrox/konflux-tasks#3
msugakov
added a commit
to stackrox/collector
that referenced
this pull request
Dec 13, 2024
To make things symmetric with the Scanner V2's task.
The pipeline is quick so these timeouts are quite generous and there's room to make them lower, but let's see how it goes.
so that the repo does not look naked.
for user's convenience.
Task bundles are architecture-neutral containers with data and so `build-image-index` is currently disabled and I'm confident we will not need to enable it in the foreseeable future. If some Tekton task needs to use some native binaries, these are provided through step's `image:` attribute. Therefore `build-image-index` is simply redundant at this point.
stackrox/stackrox#13599 will help to catch any regressions.
since it's unused for now.
After https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/3605 got merged and finally properly landed.
9ae0fcb
to
66e0b58
Compare
It occured to me after looking at the pipeline graph that the one was missing. Looks like I was always lucky that `apply-tags` got executed before `update-tasks-trust` (or maybe there are retries in the `ec` command).
/retest acs-konflux-tasks-on-push |
3 similar comments
/retest acs-konflux-tasks-on-push |
/retest acs-konflux-tasks-on-push |
/retest acs-konflux-tasks-on-push |
There was some failure during container build that seemed like a bug. It got resolved after I manually deleted a tag from Quay repo. Let's keep an eye on this in the future.
Affected |
msugakov
added a commit
to stackrox/scanner
that referenced
this pull request
Dec 17, 2024
After stackrox/konflux-tasks#3 was merged and pushed them.
msugakov
added a commit
to stackrox/collector
that referenced
this pull request
Dec 17, 2024
msugakov
added a commit
to stackrox/collector
that referenced
this pull request
Dec 17, 2024
Possible now after stackrox/konflux-tasks#3 got merged.
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 17, 2024
which come from stackrox/konflux-tasks#3
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 17, 2024
After stackrox/konflux-tasks#3 got merged.
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 18, 2024
which come from stackrox/konflux-tasks#3
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 18, 2024
After stackrox/konflux-tasks#3 got merged.
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 20, 2024
which come from stackrox/konflux-tasks#3
msugakov
added a commit
to stackrox/stackrox
that referenced
this pull request
Dec 20, 2024
After stackrox/konflux-tasks#3 got merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
determine-image-tag
isn't great but it will not be the right time to address that now. Let's leave that for ROX-27384 or, most likely, ROX-26026.clair-scan
andclamav-scan
but they aren't failing the pipeline either, and so I decided to keep them in the hopes that one day they may start working. By keeping the tasks it will hopefully be easier to conform EC when that will be required.Links
determine-image-tag
to trusted task collector#1992Testing