Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27350: Setup ACS trusted tasks builds and publishing #3

Merged
merged 35 commits into from
Dec 17, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Dec 11, 2024

Notes

  • This change can be reviewed per commits as I broke it down in chunks and put descriptions that seemed meaningful. However, due the large number of commits, it can be quicker to just review the final version.
  • I know that duplication in determine-image-tag isn't great but it will not be the right time to address that now. Let's leave that for ROX-27384 or, most likely, ROX-26026.
  • Some tasks in the build pipeline don't feel quite fine, e.g. clair-scan and clamav-scan but they aren't failing the pipeline either, and so I decided to keep them in the hopes that one day they may start working. By keeping the tasks it will hopefully be easier to conform EC when that will be required.

Links

Testing

  • Tested builds in the consuming repos are fine with the new tasks. See the PRs linked above.
  • EC status is hard to present due to known issues of EC logs disappearing but I'm confident from earlier testing that all should be good once we update the policy.

@msugakov msugakov force-pushed the misha/ROX-27350-initial-setup branch 11 times, most recently from a98d0a0 to 4056835 Compare December 12, 2024 10:59
@msugakov msugakov force-pushed the misha/ROX-27350-initial-setup branch 3 times, most recently from b798fe8 to 6921801 Compare December 12, 2024 12:17
@msugakov msugakov changed the title ROX-27350: WIP ROX-27350: Setup ACS trusted tasks builds and publishing Dec 12, 2024
msugakov added a commit to stackrox/collector that referenced this pull request Dec 12, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 12, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 12, 2024
@msugakov msugakov force-pushed the misha/ROX-27350-initial-setup branch 6 times, most recently from 9a6400e to 1c67bf3 Compare December 13, 2024 10:53
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 13, 2024
msugakov added a commit to stackrox/collector that referenced this pull request Dec 13, 2024
@msugakov msugakov requested a review from kylape December 13, 2024 11:32
To make things symmetric with the Scanner V2's task.
The pipeline is quick so these timeouts are quite generous and
there's room to make them lower, but let's see how it goes.
so that the repo does not look naked.
Task bundles are architecture-neutral containers with data and so
`build-image-index` is currently disabled and I'm confident we
will not need to enable it in the foreseeable future.

If some Tekton task needs to use some native binaries, these are
provided through step's `image:` attribute.

Therefore `build-image-index` is simply redundant at this point.
since it's unused for now.
@msugakov msugakov force-pushed the misha/ROX-27350-initial-setup branch from 9ae0fcb to 66e0b58 Compare December 17, 2024 12:49
It occured to me after looking at the pipeline graph that the one
was missing. Looks like I was always lucky that `apply-tags` got
executed before `update-tasks-trust` (or maybe there are retries in
the `ec` command).
@msugakov
Copy link
Contributor Author

/retest acs-konflux-tasks-on-push

3 similar comments
@msugakov
Copy link
Contributor Author

/retest acs-konflux-tasks-on-push

@msugakov
Copy link
Contributor Author

/retest acs-konflux-tasks-on-push

@msugakov
Copy link
Contributor Author

/retest acs-konflux-tasks-on-push

@msugakov msugakov merged commit 5c84623 into main Dec 17, 2024
1 check passed
@msugakov msugakov deleted the misha/ROX-27350-initial-setup branch December 17, 2024 13:11
@msugakov
Copy link
Contributor Author

There was some failure during container build that seemed like a bug. It got resolved after I manually deleted a tag from Quay repo. Let's keep an eye on this in the future.

step-build
*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)
Creating Tekton Bundle:
	- Added Task: fetch-external-networks to image
	- Added Task: retag-image to image
	- Added Task: fetch-scanner-v4-vuln-mappings to image
	- Added Task: fetch-scanner-v2-data to image
	- Added Task: determine-image-tag-stackrox to image
	- Added Task: determine-image-tag to image
	- Added Task: wait-for-image to image
Error: could not push image to registry as "quay.io/rhacs-eng/konflux-tasks:rev-019ec288c660e477572c6f36c4bcf4c39855b856": GET https://quay.io:443/v2/rhacs-eng/konflux-tasks/manifests/rev-019ec288c660e477572c6f36c4bcf4c39855b856: MANIFEST_UNKNOWN: manifest unknown; map[]

Affected

  1. https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs-konflux-tasks/pipelineruns/acs-konflux-tasks-on-push-jxc8v
  2. https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs-konflux-tasks/pipelineruns/acs-konflux-tasks-on-push-vnl75

msugakov added a commit to stackrox/scanner that referenced this pull request Dec 17, 2024
After stackrox/konflux-tasks#3 was merged
and pushed them.
msugakov added a commit to stackrox/collector that referenced this pull request Dec 17, 2024
msugakov added a commit to stackrox/collector that referenced this pull request Dec 17, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 17, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 17, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 18, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 18, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 20, 2024
msugakov added a commit to stackrox/stackrox that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants