feat: setup devenv observability #1105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and prometheus config files
djordon
requested review from
Jiloc,
matteojug,
AshtonStephens and
cylewitruk
aldur
reviewed
Dec 12, 2024
docker/docker-compose.yml
Outdated
| - observability | ||
|
|
||
| grafana: | ||
| image: grafana/grafana:10.2.3-ubuntu |
There was a problem hiding this comment.
Updated in 28a0436.
aldur
reviewed
Dec 12, 2024
docker/docker-compose.yml
Outdated
| @@ -610,3 +614,54 @@ services: | |||
| command: "./wait-for-it.sh mariadb:3306 --timeout=720 --strict -- ./start.sh" | |||
| profiles: | |||
| - bitcoin-mempool | |||
|
|
|||
| prometheus: | |||
| image: prom/prometheus:v2.45.2 | |||
There was a problem hiding this comment.
Updated in 28a0436.
aldur
reviewed
Dec 12, 2024
docker/vector.toml
Outdated
Comment on lines
15
to
21
| type = "prometheus_scrape" | ||
| endpoints = [ | ||
| "http://host.docker.internal:9181", | ||
| "http://host.docker.internal:9182", | ||
| "http://host.docker.internal:9183", | ||
| ] | ||
|
|
There was a problem hiding this comment.
Oh! I didn't knew we could do this with vector! So we can use the same stack to push signer metrics (if they allow us to!)
There was a problem hiding this comment.
Yup, it's a great tool.
matteojug
reviewed
Dec 12, 2024
matteojug
reviewed
Jan 29, 2025
| @@ -67,7 +67,7 @@ exec_run() { | |||
| . "$ENV_PATH/signer-$i.env" \ | |||
| && export RUST_LOG="$LOG_SETTINGS" \ | |||
| && export SIGNER_SIGNER__BOOTSTRAP_SIGNING_SET="$BOOTSTRAP_SIGNER_SET" \ | |||
| && cargo run --bin signer -- --config "$SIGNER_CONFIG" --migrate-db > "$PWD/target/signer-$i.log" 2>&1 \ | |||
| && cargo run --bin signer -- --config "$SIGNER_CONFIG" --migrate-db -o json > "$PWD/target/signer-$i.log" 2>&1 \ | |||
There was a problem hiding this comment.
Can we add a flag to control the -o json? Otherwise checking the logs when running this natively will be quite annoying.
| @@ -30,6 +30,10 @@ x-common-vars: | |||
| - &REWARD_RECIPIENT ${REWARD_RECIPIENT:-STQM73RQC4EX0A07KWG1J5ECZJYBZS4SJ4ERC6WN} # priv: 6ad9cadb42d4edbfbe0c5bfb3b8a4125ddced021c4174f829b714ccbf527f02001 | |||
| - &EXIT_FROM_MONITOR 1 # set to "1" to automatically shut down via monitor.ts | |||
|
|
|||
| volumes: | |||
| # prometheus-data: {} | |||
| grafana-data1: {} | |||
There was a problem hiding this comment.
nit: do we want the trailing 1?
qq: why do we want a volume for one but not the other?
| - grafana-data1:/var/lib/grafana | ||
| - ./grafana/provisioning/:/etc/grafana/provisioning/ | ||
| ports: | ||
| - 3030:3000 |
There was a problem hiding this comment.
This port is already used for the blocklist client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1104
This just sets up metrics. Logs will come in a separate PR.
Changes
Testing Information
I tested this locally and everything worked as expected.
Checklist: