Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for first signer set #1117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add test for first signer set #1117

wants to merge 2 commits into from

Conversation

friedger
Copy link
Contributor

Description

This PR adds a test for clarity to calculate the current signer from the first signer set at launch of sbtc

Changes

  • added new file

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@friedger friedger force-pushed the chore/first-signer-set branch from fff4df2 to 6880347 Compare December 13, 2024 09:51
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This largely looks good. The only worry is that this test gives the wrong impression about the testnet address for the sbtc signers. I would add a comment that clarifies that the testnet address here is not the one to actually expect on testnet.

Comment on lines +29 to +33
// testnet signer address from contract
const currentSigner = rov(
signers.pubkeysToPrincipal(keys, signatureThreshold)
);
expect(currentSigner).toEqual("SN3VDXK3WZZSA84XXFKAFAF15NNZX32CTSJV6BTWG");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose having it here is fine, but this isn't the sbtc signers' address on testnet. I would update the comment above to say that this is what the signers' address would be on testnet if the above public keys were used there. The mainnet one is the correct one though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants