feat: check the withdrawal status during validation #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcceptWithdrawalV1 struct to a qualified id
to use the withdrawal report.
of a withdrawal request
the call to is_withdrawal_completed
xoloki
approved these changes
Feb 19, 2025
setzeus
requested changes
Feb 19, 2025
RejectWithdrawalV1::validate docstrings
reject withdrawal request_completed validation test
setzeus
approved these changes
Feb 19, 2025
matteojug
reviewed
Feb 20, 2025
Base automatically changed from
1376-check-if-withdrawal-is-completed-during-validation
to
main
February 20, 2025 17:19
matteojug
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1376
Changes
AcceptWithdrawalV1andRejectWithdrawalV1to check the smart contract for whether the withdrawal request has completed.Testing Information
This PR adds two new integration tests, one for
AcceptWithdrawalV1and another forRejectWithdrawalV1, that check for the correct result depending on the Stacks node response.Checklist: