[feature]: sign and broadcast accept-withdrawal contract call
#1403
Conversation
|
@djordon can you please take a brief look? It is not ready, just to double-check that I'm working in correct direction |
|
So far so good! Now for the most fun part, the tests! |
| // Await for tenure completion | ||
| let tenure_completed_signal = TxCoordinatorEvent::TenureCompleted.into(); | ||
|
|
||
| println!("Waiting for tenure completion"); | ||
| context |
There was a problem hiding this comment.
Hmm, I'm getting stack overflow here and think it is weird...
There was a problem hiding this comment.
Oh, no, I found where it comes from
| @@ -1034,7 +1034,7 @@ impl PartialOrd for StacksPrincipal { | |||
|
|
|||
| /// A ScriptPubkey of a UTXO. | |||
| #[derive(Debug, Clone, Hash, PartialEq, Eq, PartialOrd, Ord)] | |||
| pub struct ScriptPubKey(bitcoin::ScriptBuf); | |||
| pub struct ScriptPubKey(pub bitcoin::ScriptBuf); | |||
There was a problem hiding this comment.
I don't think that we should make this public. We should have what we need with our Deref and From implementations.
There was a problem hiding this comment.
Yeaaa, it is still dirty, but I was struggling a bit to extract inner from it, so temporarly did this =(
|
Well, if it passes also in CI I'd say that major part of work is done. There are a lot of cleanup to do, and some test cases to cover (for example when withdrawal request was far enough to be rejected). But I think it will be much less work than this base test cases, so if they are ok I think we will be able to merge it soon |
|
Hey, @djordon ! I know that this PR still need some polishing, removing debug prints and some style improvements. But can you please confirm/refute that this test describes coordinator behaviour we expect? Also maybe you see some important test cases I didn't add? |
I think the test is confirms the behavior that we expect, specifically the |
Description
Closes: #1385
WIP
Changes
Testing Information
Checklist: